[CSApply] Sendable-to-Any: Add support for l-value to l-value and inout unsafe casts #78487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`coerceToType` can to handle l-value -> inout correctly and report better information if coercion fails.
…econcurrency context
… equality If type equality check fails we need to check whether the types are the same with deep equality restriction since `any Sendable` to `Any` conversion is now supported in generic argument positions of @preconcurrency declarations. i.e. referencing a member on `[any Sendable]` if member declared in an extension that expects `Element` to be equal to `Any`.
`any Sendable` -> `Any` in generic argument positions should be supported for l-value and inout types as well otherwise it won't be possible to call setters and mutating methods.
|
I reached out to @jckarter about SILGen side of this and we decided that it would be best to use existing |
|
@swift-ci please test |
xedin
changed the title
hborla
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
any Sendable->Anyin generic argument positions should besupported for l-value and inout types as well otherwise it won't
be possible to call setters and mutating methods.
This means that we cannot reply on simple type equality in some
cases i.e. when applying base to
selfparameter. If type equalitycheck fails we need to check whether the types are the same with
deep equality restriction since
any SendabletoAnyconversionis now supported in generic argument positions of
@preconcurrencydeclarations. i.e. referencing a member on
[any Sendable]if memberdeclared in an extension that expects
Elementto be equal toAny.