-
Notifications
You must be signed in to change notification settings - Fork 10.5k
CMake: SwiftCore: Add back SWIFT_STDLIB_SUPPORTS_BACKTRACE_REPORTING #78497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMake: SwiftCore: Add back SWIFT_STDLIB_SUPPORTS_BACKTRACE_REPORTING #78497
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not confusing at all 🤦♂️
This setting controls the backtrace that you get from |
Okay, I can give this a better description then. |
6a7f7b7
to
3c01edd
Compare
@swift-ci please smoke test |
@swift-ci please smoke test Windows |
Add an option to enable emitting a stacktrace on calls to `fatalError`. This is unrelated to the runtime backtracer for diagnosing normal Swift crashes. rdar://142440689
3c01edd
to
5aadace
Compare
@swift-ci please smoke test |
@swift-ci please test Windows |
@swift-ci please smoke test |
Do we not have a formatter that formats the CMakeLists to a defined style? |
No. I am trying to keep it at least somewhat consistent within the new parts of the build with two-space indentation and putting closing parens on the last line, but that's about it. |
So, despite the name, this is not the same as enabling backtracing.... Somehow. Anyway, this was a macro from the old build that we want in the new build.
@mikeash and @al45tair, is there some way that we can merge these concepts or at least have a better description of how they differ.
rdar://142440689