[cxx-interop] Check the safety of C++ template arguments #78522
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xazax-hun
requested review from
zoecarver,
hyp,
egorzhdan,
beccadax and
ian-twilightcoder
as code owners
|
@swift-ci please smoke test |
Xazax-hun
force-pushed
the
gaborh/instantiation-unsafe
branch
from
62ff0d6 to
9856c1d
Compare
|
@swift-ci please smoke test |
|
@swift-ci please build toolchain macOS |
Xazax-hun
force-pushed
the
gaborh/instantiation-unsafe
branch
from
9856c1d to
d6499b8
Compare
|
@swift-ci please smoke test |
egorzhdan
reviewed
Jan 17, 2025
lib/ClangImporter/ImportDecl.cpp
Outdated
Comment on lines
2197
to
2198
| if (arg.getKind() != clang::TemplateArgument::Type) | ||
| continue; |
There was a problem hiding this comment.
Would this work with pack arguments, e.g. std::tuple<Safe, Safe, Unsafe>?
There was a problem hiding this comment.
Good catch! Added support or that.
Swift imports template specializations as a standalone type (not as an instantiation of a generic) so unsafety is not propagated from the template arguments to the specialization. This PR propagates this information explicitly.
Xazax-hun
force-pushed
the
gaborh/instantiation-unsafe
branch
from
d6499b8 to
f12b48a
Compare
|
@swift-ci please smoke test |
|
@swift-ci please smoke test linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swift imports template specializations as a standalone type (not as an instantiation of a generic) so unsafety is not propagated from the template arguments to the specialization. This PR propagates this information explicitly.