Skip to content

[6.1][Sema] Look through ActorIsolationErasureExpr when finding function… #78536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

xedin
Copy link
Contributor

@xedin xedin commented Jan 10, 2025

… DeclRefs for rethrows checking.

Cherry-pick of #78535


  • Explanation:

    Fixes a source compatibility regression when actor isolated function values are passed to throwing parameters.

    This conversion has no effect on rethrows checking and should be ignored.

  • Main Branch PR: [Sema] Look through ActorIsolationErasureExpr when finding function… #78535

  • Resolves: rdar://142562250

  • Risk: Very Low (this conversion appears in a limit set of circumstances and has no effect on rethrows checking).

  • Reviewed By: @hborla

  • Testing: Added new tests to the Concurrency test suite.

(cherry picked from commit e0bfa13)

@xedin xedin requested a review from a team as a code owner January 10, 2025 00:15
@xedin xedin requested a review from hborla January 10, 2025 00:15
@xedin
Copy link
Contributor Author

xedin commented Jan 10, 2025

@swift-ci please test

@xedin
Copy link
Contributor Author

xedin commented Jan 10, 2025

@swift-ci please clean test

… DeclRefs for `rethrows` checking.

This conversion has no effect on `rethrows` checking and should
be ignored.

Resolves: rdar://142562250
(cherry picked from commit e0bfa13)
@xedin xedin force-pushed the rdar-142562250-6.1 branch from c04d6b8 to 8e19d3a Compare January 10, 2025 17:03
@xedin
Copy link
Contributor Author

xedin commented Jan 10, 2025

@swift-ci please test

@xedin xedin merged commit 2b28374 into swiftlang:release/6.1 Jan 10, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants