Skip to content

[gardening] move String.withCString() to String.swift #78540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

glessard
Copy link
Contributor

@glessard glessard commented Jan 10, 2025

This function has been at an unexpected location for unremembered reasons for far too long.
Move it to the main String source file, alongside the other String.withCString() function.

- it has been at an unexpected location for unremembered reasons.
@glessard glessard requested a review from a team as a code owner January 10, 2025 06:19
@glessard
Copy link
Contributor Author

@swift-ci please smoke test

Copy link
Contributor

@Catfish-Man Catfish-Man left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glessard glessard merged commit 12675dd into swiftlang:main Jan 10, 2025
3 checks passed
@glessard glessard deleted the string-gardening branch January 10, 2025 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants