AST: Refactor AvailableAttr representation to use AvailabilityDomain
#78541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AvailableAttr::Kind and AvailabilityDomain are designed to replace PlatformAgnosticAvailabilityKind, allowing AvailableAttr to more flexibly model availability for arbitrary domains. For now, the new constructor just translates its inputs into inputs for the existing constructor. Once all of the callers of the existing AvailableAttr constructor have been updated to use the new constructor, the representation of AvailableAttr will be updated to store the new properties.
The platform field now indicates whether the attribute applies universally, to a specific platform, to the Swift language, or to package descriptions. Additionally the output now reflects whether or not the attribute specifies unconditional deprecation or unavailabity or is `noasync`.
It was difficult to preserve the existing, buggy behavior of availability attribute inference with respect to attributes specifying availability for non-platform-specific domains. Instead, this change improves attribute merging by tracking every domain independently, and only merging attributes from the same domain.
tshortli
force-pushed
the
available-attr-remodel
branch
from
ec0a4bb to
1d47307
Compare
tshortli
requested review from
xymus,
hborla,
slavapestov,
xedin,
ahoppen,
bnbarham,
CodaFi,
DougGregor,
hamishknight,
rintaro,
zoecarver,
hyp,
egorzhdan,
beccadax,
ian-twilightcoder and
Xazax-hun
as code owners
I can't believe it's really happening.
tshortli
force-pushed
the
available-attr-remodel
branch
from
1d47307 to
c0e01dc
Compare
|
@swift-ci please test |
|
@swift-ci please build toolchain macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the
PlatformKindandPlatformAgnosticAvailabilityKindproperties ofAvailableAttrwithAvailabilityDomainandAvailableAttr::Kind. This will allow@availableattributes to model availability for arbitrary domains, instead of just a predefined set of platforms plus theswiftand_PackageDescriptiondomains. Since resolving the domain specified by an attribute may require performing a name lookup in the future,getCachedDomain()returns an optional even though currently the domain is always fully resolved during parsing.This PR is mostly NFC, with two notable exceptions:
ASTDumperoutput forAvailableAttrhas been corrected and expanded.@availableattributes but now generates correct ones.