embedded: make sure to generate witness tables which are imported from other modules #78555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci smoke test |
kubamracek
approved these changes
Jan 10, 2025
|
Nice, thanks! |
…m other modules In embedded swift all the code is generated in the top-level module. De-serialized witness tables for class existentials must be code-gen'd and therefore made non-external. Fixes an unresolved symbol linker error. rdar://142561676
… imported from other modules. Only generate code lazily for such functions, i.e. only if such a function is referenced from already generated code. This is achieved by converting the SILLinkage for `public_external` functions to `internal` instead of `public in IRGenPrepare.
eeckstein
force-pushed
the
witness-table-linkage
branch
from
7432d9d to
9d0fc8b
Compare
|
@swift-ci smoke test |
|
@swift-ci benchmark |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In embedded swift all the code is generated in the top-level module. De-serialized tables must be code-gen'd and therefore made non-external.
This also requires another change: in IRGen, don't force generate code for functions which are imported from other modules.
Only generate code lazily for such functions, i.e. only if such a function is referenced from already generated code.
This is achieved by converting the SILLinkage for
public_externalfunctions tointernalinstead ofpublicin IRGenPrepare.Fixes an unresolved symbol linker error.
rdar://142561676