-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Add a reproducer for issue 78447 #78563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. We did already have a source level test for the fix, but this test exhibits the compiler crash rather than just checking the SIL output. So it may have some value.
Would it not be better to put this in |
@AnthonyLatsis I think any place that's run for each pre-submit PR would be good. Does the pre-submit PR CI run |
Your test will definitely run. Some tests in the validation suite are not normally run, but this is due to metaprogrammed requirements in them rather than their location. I think we should avoid using |
aa3e409
to
7abb94a
Compare
@swift-ci please test |
Moved the test to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@swift-ci please test macos platform |
#78447