Skip to content

Add a reproducer for issue 78447 #78563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Conversation

hjyamauchi
Copy link
Contributor

@hjyamauchi hjyamauchi requested a review from atrick January 10, 2025 22:21
@hjyamauchi
Copy link
Contributor Author

hjyamauchi commented Jan 10, 2025

@atrick Could this be useful? I'm not sure if this duplicates the tests in #78482.

Copy link
Contributor

@atrick atrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. We did already have a source level test for the fix, but this test exhibits the compiler crash rather than just checking the SIL output. So it may have some value.

@AnthonyLatsis
Copy link
Collaborator

Would it not be better to put this in validation-test/SILOptimizer?

@hjyamauchi
Copy link
Contributor Author

@AnthonyLatsis I think any place that's run for each pre-submit PR would be good. Does the pre-submit PR CI run validation-test/SILOptimizer?

@AnthonyLatsis
Copy link
Collaborator

Your test will definitely run. Some tests in the validation suite are not normally run, but this is due to metaprogrammed requirements in them rather than their location. I think we should avoid using test/Misc as a dumping ground any further. We need to distribute those tests to dedicated folders and delete it.

@hjyamauchi
Copy link
Contributor Author

@swift-ci please test

@hjyamauchi
Copy link
Contributor Author

Your test will definitely run. Some tests in the validation suite are not normally run, but this is due to metaprogrammed requirements in them rather than their location. I think we should avoid using test/Misc as a dumping ground any further. We need to distribute those tests to dedicated folders and delete it.

Moved the test to validation-test/SILOptimizer. PTAL. @AnthonyLatsis

Copy link
Collaborator

@AnthonyLatsis AnthonyLatsis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hjyamauchi
Copy link
Contributor Author

@swift-ci please test macos platform

@hjyamauchi hjyamauchi merged commit 1d8e48d into swiftlang:main Jan 15, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants