Fix the demangling of sending result types when combined with isolation #78576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the immediate problem, but the presence of demangling code in the runtime means that we'll need a follow-up to fix the compiler so that it doesn't try to use the demangler to materialize metadata for function types that have both isolation and a sending result. rdar://142443925
|
@swift-ci Please test |
|
@swift-ci Please test Linux |
|
@AnthonyLatsis if it isn't this, there is an additional bug that I am fixing that has to do with function types/sending results that I don't think is fixed by this. I already have a patch... I would just wait for Monday before you dig in if this doesn't fix those issues... it is the weekend after all ; p |
|
No worries, I was just triaging recent issues and spotted this PR right next to one of them in my inbox. Thanks for letting me know, though! |
This was referenced Jan 15, 2025
This was
linked to
issues
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the immediate problem, but the presence of demangling code in the runtime means that we'll need a follow-up to fix the compiler so that it doesn't try to use the demangler to materialize metadata for function types that have both isolation and a sending result.
rdar://142443925