Tighten up unsafe effects checking
#78585
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check for unsafe conformances for type erasure and opaque type erasure. This also uncovered an issue where we were making every conformance of an unsafe type to an unsafe protocol @unsafe implicitly, even though that's not really what we want.
…larations Only "unsafe" checking is affected here.
The `unsafe` goes on the sequence expression, e.g.,
for x in unsafe mySequence { ... }
We track this information via anchor, so we don't need to manage a separate list that doesn't have an anchor.
DougGregor
requested review from
AnthonyLatsis,
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve
unsafeeffects checking to capture more potential uses of unsafe constructs:unsafewith auto closuresWhile here, fix some issues with
@unsafeconformances: they weren't being recorded as unsafe when placed on an extension (!), and we were inferring that all conformances of an unsafe type are unsafe. We don't need that, because the type being unsafe is enough.