[6.1] ConformanceChecker: Make actor_isolated_witness call out the protocol
#78605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnthonyLatsis
changed the title
actor_isolated_witness call out the protocolactor_isolated_witness call out the protocol
AnthonyLatsis
force-pushed
the
gyromitra-esculenta-6.1
branch
from
137b62b to
9bb6b0d
Compare
`x declared here` is not helpful and clear enough, especially when there are other notes attached. Swap it for a new note that says `requirement x declared here`. While we are here, also make sure we do not emit this note unless the requirement has a valid location.
AnthonyLatsis
force-pushed
the
gyromitra-esculenta-6.1
branch
from
9bb6b0d to
fd65023
Compare
DougGregor
approved these changes
Jan 14, 2025
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
actor_isolated_witnesscall out the protocol #78602