[6.1] Outliner: Do not outline if the BridgedArg value is not available at the BridgedCall #78616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the BridgedCall Avoid outlining this scenario instead of creating a copy to make the value available
This copy may remain unoptimized, avoid outlining this case.
|
@swift-ci test |
|
@swift-ci test |
tbkka
approved these changes
Jan 21, 2025
meg-gupta
force-pushed
the
outlinefix6.1
branch
from
4325184 to
1c12c7b
Compare
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: While outlining, if the BridgedArg value's is not available at the BridgedCall, bailout instead of creating a copy.
Scope: Outliner on functions in OSSA
Issues: Fixes rdar://142633893
Original PRs: #78581
Risk: Low.
Testing: Smoke test.
Reviewers: @eeckstein