Skip to content

[stdlib] fix getting eager-lazy-bridged Array buffer #78647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 15, 2025

Conversation

glessard
Copy link
Contributor

@glessard glessard commented Jan 15, 2025

Retain the appropriate reference. Fixes rdar://142867382

This will unblock swift-ci benchmarking for the x86-64 macOS target.

@glessard glessard changed the title [stdlib] fix getting eager-lazy-bridged buffer [stdlib] fix getting eager-lazy-bridged Array buffer Jan 15, 2025
@glessard
Copy link
Contributor Author

@swift-ci please smoke test macOS platform

@glessard glessard requested a review from Catfish-Man January 15, 2025 02:00
@glessard glessard marked this pull request as ready for review January 15, 2025 02:00
@glessard glessard requested a review from a team as a code owner January 15, 2025 02:00
@glessard
Copy link
Contributor Author

@swift-ci please test

@glessard glessard enabled auto-merge January 15, 2025 04:57
Copy link
Contributor

@Catfish-Man Catfish-Man left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still wish we knew how it worked on arm, but lgtm

@glessard
Copy link
Contributor Author

@swift-ci please test Windows platform

@glessard
Copy link
Contributor Author

@swift-ci please test Linux platform

@glessard glessard merged commit 346704c into swiftlang:main Jan 15, 2025
5 checks passed
@glessard glessard deleted the rdar142867382 branch January 15, 2025 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants