🍒[cxx-interop] Workaround compiler error when importing CoreGraphics with C++ interop #78657
Conversation
…ith C++ interop The CoreGraphics overlay refers to symbols declared via `CF_OPTIONS` macro, which is causing issues in C++ language mode due to the macro definition being different. This teaches the module interface loader to drop the C++ interop flag when rebuilding the CoreGraphics overlay from its interface. rdar://142762174 (cherry picked from commit d72006e)
|
@swift-ci please test |
| if (moduleName == "Darwin") { | ||
| // FIXME: Hack for CoreGraphics.swiftmodule, which cannot be rebuilt because | ||
| // of a CF_OPTIONS bug (rdar://142762174). | ||
| if (moduleName == "Darwin" || moduleName == "CoreGraphics") { |
There was a problem hiding this comment.
Can we hoist this out of the compiler and into arguments? I suspect that there will be a number of other modules that need this behaviour (I can see submodules in WinSDK wanting this as well).
There was a problem hiding this comment.
Hmm, what would be the case where we would want to apply this to a WinSDK module?
This isn't intended to be something accessible via a compiler flag, since it might result in linker errors if you try using any of the problematic types from Swift. In this case the CF_OPTIONS types are triggering a compiler bug when C++ interop is enabled, which is a bug that we'll need to fix.
There was a problem hiding this comment.
As @compnerd said, this is likely to affect other modules, so while I'm going to approve this to address the regression, I'd like us to find either a general solution to the underlying problem or to make it easier to extend the list of modules that need this workaround.
Explanation: The CoreGraphics overlay refers to symbols declared via
CF_OPTIONSmacro, which is causing issues in C++ language mode due to the macro definition being different.This teaches the module interface loader to drop the C++ interop flag when rebuilding the CoreGraphics overlay from its interface.
Scope: This changes the compiler flags used to rebuild CoreGraphics when C++ interop is enabled.
Risk: Low, this only affects rebuilding of a single SDK module from its interface when C++ interop is enabled.
Testing: Added anew compiler test.
Issue: rdar://142762174
Reviewer: @Xazax-hun
Original PR: #78636