[TempRValueOpt] Invalidate insts when completing. #78682
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Separate the propagation of copies from the setup and cleanup. Facilitates bailing after completing N subpasses.
Allow continueWithNextSubpassRun to take a SILValue.
Before each transformation is done, check whether to continue with the next subpass.
Separate the hoisting of destroys from the setup and cleanup. Facilitates bailing after completing N subpasses.
Move it to the lambda which it talks about. The old location is in a function which now enjoys multiple callers, and the comment applies to only one.
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
|
@swift-ci please apple silicon benchmark |
|
@swift-ci please test |
nate-chandler
requested review from
atrick and
meg-gupta
and removed request for
jckarter
|
@swift-ci please test |
meg-gupta
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several small improvements pulled out of #78651 .