Skip to content

[IRGen] Add indirect typed error slot when async function has indirec… #78698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

drexin
Copy link
Contributor

@drexin drexin commented Jan 16, 2025

…t result

rdar://142918657

Erorrs have to be passed indirectly whenever the result type is indirect.

…t result

rdar://142918657

Erorrs have to be passed indirectly whenever the result type is indirect.
@drexin drexin requested a review from rjmccall as a code owner January 16, 2025 23:46
@drexin
Copy link
Contributor Author

drexin commented Jan 16, 2025

@swift-ci smoke test

Copy link
Contributor

@aschwaighofer aschwaighofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This matches with the logic in void SignatureExpansion::addIndirectThrowingResult()

LGTM

@drexin
Copy link
Contributor Author

drexin commented Jan 17, 2025

@swift-ci smoke test linux

2 similar comments
@drexin
Copy link
Contributor Author

drexin commented Jan 17, 2025

@swift-ci smoke test linux

@drexin
Copy link
Contributor Author

drexin commented Jan 17, 2025

@swift-ci smoke test linux

@porglezomp
Copy link
Contributor

@swift-ci please smoke test linux

@drexin drexin merged commit 59e07f1 into swiftlang:main Jan 21, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants