Skip to content

[6.1] Sema: Partially revert #77236 #78701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 20, 2025
Merged

[6.1] Sema: Partially revert #77236 #78701

merged 1 commit into from
Jan 20, 2025

Conversation

tshortli
Copy link
Contributor

@tshortli tshortli commented Jan 17, 2025 •
edited
Loading

  • Explanation: Partially revert Sema: Eliminate some piecemeal unavailability diagnostics #77236 in order to work around some issues related to the way @_spi attributes are printed and checked in swiftinterfaces.
  • Scope: Modules with library evolution enabled and properties that are both annotated with @_spi and have attached property wrappers.
  • Issue/Radar: rdar://143029729
  • Original PR: N/A (this will be fixed separately on main)
  • Risk: Low, returns behavior to the shipping status quo.
  • Testing: Existing compiler tests.
  • Reviewer: @xymus

@tshortli
Sema: Partially revert swiftlang#77236.
c520fd6 
Partially revert swiftlang#77236 in order to work
around some issues related to the way `@_spi` attributes are printed and
checked in swiftinterfaces.

Resolves rdar://143029729.
@tshortli tshortli requested a review from a team as a code owner January 17, 2025 00:53
@tshortli
Copy link
Contributor Author

@swift-ci please test

@tshortli tshortli enabled auto-merge January 17, 2025 01:01
@tshortli tshortli changed the title [6.1] Sema: Partially revert https://github.com/swiftlang/swift/pull/77236 [6.1] Sema: Partially revert #77236 Jan 17, 2025
@tshortli
Copy link
Contributor Author

@swift-ci please test Windows

2 similar comments
@tshortli
Copy link
Contributor Author

@swift-ci please test Windows

@tshortli
Copy link
Contributor Author

@swift-ci please test Windows

@tshortli tshortli merged commit 8eaad45 into swiftlang:release/6.1 Jan 20, 2025
5 checks passed
@tshortli tshortli deleted the revert-refactor-diagnose-explicit-unavailability-6.1 branch January 21, 2025 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkcsgexi nkcsgexi nkcsgexi approved these changes

Assignees
No one assigned
Labels
swift 6.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tshortli @nkcsgexi