[Swiftify][ClangImporter] Import noescape attribute for parameters #78713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hnrklssn
requested review from
zoecarver,
hyp,
beccadax and
ian-twilightcoder
as code owners
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
Xazax-hun
approved these changes
Jan 20, 2025
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
hnrklssn
force-pushed
the
swiftify-clangimport-noescape
branch
from
b78747e to
b986ed2
Compare
|
@swift-ci please smoke test |
1 similar comment
|
@swift-ci please smoke test |
|
@swift-ci please smoke test macos |
This passes along the noescape attribute to @_SwiftifyImport as .noescape(pointer: .param(X)). This allows importing parameters as Span, MutableSpan and RawSpan.
hnrklssn
force-pushed
the
swiftify-clangimport-noescape
branch
from
b986ed2 to
80b7c76
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This passes along the noescape attribute to @_SwiftifyImport as .noescape(pointer: .param(X)). This allows importing parameters as Span, MutableSpan and RawSpan.