[6.1] Sema: Ensure access-level on imports only applies to visible imported decls #78718
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ible Access-level on imports is designed to downgrade the visibility of imported decls. Add a check to apply this logic only to decls that were originally visible: public and same-package. rdar://143008763
|
@swift-ci Please test |
nkcsgexi
approved these changes
Jan 17, 2025
|
@swift-ci Please test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Access-level on imports are designed to downgrade the visibility of imported decls. Add a check to apply this logic only to decls that were originally visible: public and same-package decls. Otherwise a
private importcan allow a partial visibility into an imported internal decl.privateandinternalimports.