Skip to content

TypeCheckType: Rework IUO diagnostics using behavior limitation #78739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

AnthonyLatsis
Copy link
Collaborator

Also stop suggesting a '?' fix-it for casts, where it is not likely to be helpful because the common intention is either to force the optional or declare an IUO.

Copy link
Contributor

@xedin xedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@xedin
Copy link
Contributor

xedin commented Jan 21, 2025

@swift-ci please test

Also stop suggesting a '?' fix-it for casts, where it is not likely to
be helpful because the common intention is either to force the optional
or declare an IUO.
@AnthonyLatsis
Copy link
Collaborator Author

@swift-ci please test

@AnthonyLatsis
Copy link
Collaborator Author

@swift-ci please test Linux

@AnthonyLatsis
Copy link
Collaborator Author

@swift-ci please test Windows

@AnthonyLatsis AnthonyLatsis merged commit 499146d into swiftlang:main Jan 22, 2025
5 checks passed
@AnthonyLatsis AnthonyLatsis deleted the hatzegopteryx branch January 22, 2025 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants