Skip to content

[Gardening] Fix some set but not used variables #78750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 31, 2025
Merged

[Gardening] Fix some set but not used variables #78750

merged 1 commit into from
Jan 31, 2025

Conversation

AnthonyLatsis
Copy link
Collaborator

No description provided.

AnthonyLatsis
AnthonyLatsis commented Jan 19, 2025
View reviewed changes
ktoso
ktoso approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@ktoso ktoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in Distributed or Concurrency files look ok AFAICS

ahoppen
ahoppen approved these changes Jan 20, 2025
View reviewed changes
Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Changes in IDE and Index look good to me.

Xazax-hun
Xazax-hun approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@Xazax-hun Xazax-hun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ClangImporter changes look good to me. Thanks!

hamishknight
hamishknight approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@hamishknight hamishknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Profiler + IDE changes LGTM

@jamieQ
Copy link
Contributor

jamieQ commented Jan 20, 2025

tangent: out of curiosity, how did you identify these @AnthonyLatsis?

@AnthonyLatsis
Copy link
Collaborator Author

I used a recent dev clang.

xedin
xedin approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@xedin xedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sema changes look good to me, thank you!

aschwaighofer
aschwaighofer reviewed Jan 27, 2025
View reviewed changes
Copy link
Contributor

@aschwaighofer aschwaighofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 approve the IRGen changes

eeckstein
eeckstein reviewed Jan 28, 2025
View reviewed changes
Copy link
Contributor

@eeckstein eeckstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SIL/SILGen/Optimizer changes lgtm

@AnthonyLatsis
Copy link
Collaborator Author

Thanks everyone, I am vouching myself for the rest.

@AnthonyLatsis
Copy link
Collaborator Author

@swift-ci please smoke test

@AnthonyLatsis AnthonyLatsis merged commit 34f9b80 into swiftlang:main Jan 31, 2025
3 checks passed
@AnthonyLatsis AnthonyLatsis deleted the oryza-sativa branch January 31, 2025 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aschwaighofer aschwaighofer aschwaighofer left review comments

@xedin xedin xedin approved these changes

@ktoso ktoso ktoso approved these changes

@Xazax-hun Xazax-hun Xazax-hun approved these changes

@ahoppen ahoppen ahoppen approved these changes

@hamishknight hamishknight hamishknight approved these changes

@eeckstein eeckstein eeckstein approved these changes

@xymus xymus Awaiting requested review from xymus xymus is a code owner

@hborla hborla Awaiting requested review from hborla hborla is a code owner

@slavapestov slavapestov Awaiting requested review from slavapestov slavapestov is a code owner

@tshortli tshortli Awaiting requested review from tshortli tshortli is a code owner

@kavon kavon Awaiting requested review from kavon kavon is a code owner

@jckarter jckarter Awaiting requested review from jckarter jckarter is a code owner

@bnbarham bnbarham Awaiting requested review from bnbarham bnbarham is a code owner

@rintaro rintaro Awaiting requested review from rintaro rintaro is a code owner

@nkcsgexi nkcsgexi Awaiting requested review from nkcsgexi nkcsgexi is a code owner

@rjmccall rjmccall Awaiting requested review from rjmccall rjmccall is a code owner

@artemcm artemcm Awaiting requested review from artemcm artemcm is a code owner

@MaxDesiatov MaxDesiatov Awaiting requested review from MaxDesiatov MaxDesiatov is a code owner

@etcwilde etcwilde Awaiting requested review from etcwilde etcwilde is a code owner

@zoecarver zoecarver Awaiting requested review from zoecarver zoecarver is a code owner

@hyp hyp Awaiting requested review from hyp

@egorzhdan egorzhdan Awaiting requested review from egorzhdan egorzhdan is a code owner

@beccadax beccadax Awaiting requested review from beccadax beccadax is a code owner

@ian-twilightcoder ian-twilightcoder Awaiting requested review from ian-twilightcoder ian-twilightcoder is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@AnthonyLatsis @jamieQ @xedin @slavapestov @ktoso @Xazax-hun @ahoppen @hamishknight @aschwaighofer @eeckstein