🍒[cxx-interop] Do not import std::__compressed_pair
#78758
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This type is triggering modularization issues in libc++: ``` error: definition of '__builtin_new_deleter' must be imported from module 'std_private_memory_builtin_new_allocator' before it is required ``` This is a workaround to keep things building. rdar://142576799 (cherry picked from commit cb2bd32)
|
@swift-ci please test |
|
@swift-ci please test Windows |
Xazax-hun
approved these changes
Jan 24, 2025
DougGregor
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: This type is triggering modularization issues in libc++:
This is a workaround to keep things building.
Risk: Low, this only affects import of one specific C++ type.
Issue: rdar://142576799
Reviewer: @Xazax-hun
Original PR: #78696