Skip to content

DependencyScan: track library style #78777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 6, 2025
Merged

DependencyScan: track library style #78777

merged 1 commit into from
Feb 6, 2025

Conversation

compnerd
Copy link
Member

Track if the dependency is static or dynamic. This is in preparation for helping rename the static library to differentiate it from import libraries.

@compnerd
Copy link
Member Author

@swift-ci please test

cachemeifyoucan
cachemeifyoucan reviewed Jan 21, 2025
View reviewed changes
Copy link
Contributor

@cachemeifyoucan cachemeifyoucan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change is fine. Do you have any documentation or writing for what is the change you are planning to do?

I think it would be better if you do both in one PR since storing info into cache that is not currently used (and cache is also mostly not used) is not very useful.

@compnerd
Copy link
Member Author

I don't want to make that change as part of this change because its really a wide-spread change. The change is going to change the autolinked libraries in Swift. When statically linking Swift libraries on Windows, it will implicitly add a lib prefix to the library to differentiate it from the import library (e.g. libArgumentParser.lib vs ArgumentParser.lib). This is to help support @etcwilde's desire to remove swift_static someday.

@compnerd
Copy link
Member Author

@swift-ci please test

cachemeifyoucan
cachemeifyoucan reviewed Jan 21, 2025
View reviewed changes
artemcm
artemcm reviewed Jan 21, 2025
View reviewed changes
Copy link
Contributor

@artemcm artemcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For completeness, this change should introduce:

swiftscan_link_library_info_get_is_static

To DependencyScan.h.

@compnerd
Copy link
Member Author

@swift-ci please test

@compnerd
Copy link
Member Author

@swift-ci please smoke test

@compnerd compnerd force-pushed the scanning branch 2 times, most recently from 938a496 to 10564f6 Compare January 23, 2025 00:47
@compnerd
Copy link
Member Author

@swift-ci please test

@compnerd
Copy link
Member Author

@swift-ci please test Windows platform

@compnerd
Copy link
Member Author

@swift-ci please test Windows platform

@compnerd
Copy link
Member Author

@swift-ci please test Windows platform

@compnerd
Copy link
Member Author

@swift-ci please test Windows platform

@compnerd
Copy link
Member Author

@swift-ci please test Windows platform

@compnerd
Copy link
Member Author

compnerd commented Feb 1, 2025

@swift-ci please smoke test macOS platform

@compnerd
Copy link
Member Author

compnerd commented Feb 1, 2025

@swift-ci please smoke test Linux platform

@compnerd
Copy link
Member Author

compnerd commented Feb 1, 2025

@swift-ci please test Linux platform

@compnerd
Copy link
Member Author

compnerd commented Feb 2, 2025

@swift-ci please test macOS platform

@compnerd
Copy link
Member Author

compnerd commented Feb 3, 2025

@swift-ci please test

@compnerd
Copy link
Member Author

compnerd commented Feb 4, 2025

@swift-ci please smoke test macOS platform

@compnerd compnerd force-pushed the scanning branch 2 times, most recently from 8a22036 to d9e15c2 Compare February 5, 2025 00:28
@compnerd
Copy link
Member Author

compnerd commented Feb 5, 2025

@swift-ci please smoke test macOS platform

@compnerd
AST,DependencyScan,IRGen,Serialization,Tooling: track library style
2edb1d9 
Track if the dependency is static or dynamic. This is in preparation for
helping rename the static library to differentiate it from import
libraries.
@compnerd
Copy link
Member Author

compnerd commented Feb 5, 2025

@swift-ci please smoke test macOS platform

@compnerd
Copy link
Member Author

compnerd commented Feb 6, 2025

@swift-ci please smoke test Linux platform

@compnerd
Copy link
Member Author

compnerd commented Feb 6, 2025

@swift-ci please test Windows platform

@compnerd compnerd merged commit 9c85fbc into swiftlang:main Feb 6, 2025
3 checks passed
@compnerd compnerd deleted the scanning branch February 6, 2025 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artemcm artemcm artemcm approved these changes

@cachemeifyoucan cachemeifyoucan cachemeifyoucan approved these changes

@xymus xymus Awaiting requested review from xymus xymus is a code owner

@rjmccall rjmccall Awaiting requested review from rjmccall rjmccall is a code owner

@tshortli tshortli Awaiting requested review from tshortli tshortli is a code owner

@zoecarver zoecarver Awaiting requested review from zoecarver zoecarver is a code owner

@hyp hyp Awaiting requested review from hyp

@egorzhdan egorzhdan Awaiting requested review from egorzhdan egorzhdan is a code owner

@beccadax beccadax Awaiting requested review from beccadax beccadax is a code owner

@ian-twilightcoder ian-twilightcoder Awaiting requested review from ian-twilightcoder ian-twilightcoder is a code owner

@Xazax-hun Xazax-hun Awaiting requested review from Xazax-hun Xazax-hun is a code owner

@hborla hborla Awaiting requested review from hborla hborla is a code owner

@slavapestov slavapestov Awaiting requested review from slavapestov slavapestov is a code owner

@xedin xedin Awaiting requested review from xedin xedin is a code owner

@shahmishal shahmishal Awaiting requested review from shahmishal

@etcwilde etcwilde Awaiting requested review from etcwilde

@edymtt edymtt Awaiting requested review from edymtt

@justice-adams-apple justice-adams-apple Awaiting requested review from justice-adams-apple

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@compnerd @artemcm @cachemeifyoucan