[6.1] Build swift-testing as part of the compat-suite toolchain #78787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bnbarham
commented
Jan 21, 2025
bnbarham
commented
- Explanation: Various projects (vapor in particular) now depend on swift-testing. The current Xcode installation doesn't contain it and we're not building it, so they're failing. Update the base compat suite preset to also build swift-testing (and its macros).
- Scope: Compatibility suite builds
- Original PRs: Build swift-testing as part of the compat-suite toolchain #78575
- Risk: Extremely low, just building swift-testing in the compat suite preset (which we're already doing elsewhere)
- Testing: Main compat suite now passing with this change
- Reviewers: @etcwilde
Various projects (vapor in particular) now depend on swift-testing. The current Xcode installation doesn't contain it and we're not building it, so they're failing. Update the base compat suite preset to also build swift-testing (and its macros). (cherry picked from commit 57331b2)
|
@swift-ci please test |
shahmishal
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.