[cxx-interop] Fix spurious lifetime dependence errors #78807
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xazax-hun
requested review from
zoecarver,
hyp,
egorzhdan,
beccadax and
ian-twilightcoder
as code owners
|
@swift-ci please smoke test |
egorzhdan
reviewed
Jan 22, 2025
Comment on lines
+2429
to
+2432
| // TODO: builtin "zeroInitializer" does not work with non-escapable | ||
| // types yet. Don't generate an initializer. |
There was a problem hiding this comment.
Do you know if we're tracking this issue yet?
There was a problem hiding this comment.
I wasn't able to find anything. Will ask around if people are aware of this.
There was a problem hiding this comment.
I opened one just in case: rdar://143828851
ClangImporter will generate value and default initializers for certain structs imported from C++. These generated initializers have no associated lifetime dependence information so they will trigger spurious errors for non-escapable types. This patch makes sure these are marked as unsafe so the type checker will not generate errors for them. Moreover, the generated default initializer would trigger a crash for non-escapable types as the builtin to zero initialize an object does not support non-escapable types yet. rdar://143040862
Xazax-hun
force-pushed
the
gaborh/generated-ctors
branch
from
c9cd3c5 to
b6fce85
Compare
|
@swift-ci please smoke test |
egorzhdan
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ClangImporter will generate value and default initializers for certain structs imported from C++. These generated initializers have no associated lifetime dependence information so they will trigger spurious errors for non-escapable types. This patch makes sure these are marked as unsafe so the type checker will not generate errors for them. Moreover, the generated default initializer would trigger a crash for non-escapable types as the builtin to zero initialize an object does not support non-escapable types yet.
rdar://143040862