Skip to content

[Serialization] @execution attribute should serialize behavior (not… #78834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

xedin
Copy link
Contributor

@xedin xedin commented Jan 23, 2025

… kind)

The kind is serialize separately, the attribute record itself should store execution behavior kind instead.

… kind)

The kind is serialize separately, the attribute record itself should
store execution behavior kind instead.
@xedin xedin requested a review from xymus as a code owner January 23, 2025 01:50
@xedin
Copy link
Contributor Author

xedin commented Jan 23, 2025

@swift-ci please smoke test

@xedin
Copy link
Contributor Author

xedin commented Jan 23, 2025

I'm a bit surprised that the test I committed in my original PR didn't catch this.

@gottesmm gottesmm self-requested a review January 23, 2025 03:10
@gottesmm
Copy link
Contributor

LGTM. Thanks for the fix.

@xedin
Copy link
Contributor Author

xedin commented Jan 23, 2025

@swift-ci please smoke test macOS platform

@xedin
Copy link
Contributor Author

xedin commented Jan 23, 2025

@swift-ci please smoke test Linux platform

@xedin xedin merged commit 4b595b1 into swiftlang:main Jan 23, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants