Skip to content

[6.1][Index] Skip mapping locations when there is no buffer ID #78836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 23, 2025
Merged

[6.1][Index] Skip mapping locations when there is no buffer ID #78836

merged 1 commit into from
Jan 23, 2025

Conversation

bnbarham
Copy link
Contributor

  • Explanation: Fixes a crash when no SourceFile is passed through to the indexer, but the indexed declaration still has a SourceLocation.
  • Scope: Indexing
  • Issues: rdar://143281338
  • Original PRs: [Index] Skip mapping locations when there is no buffer ID #78835
  • Risk: Extremely low, just adds a check for whether we have a buffer ID or not
  • Testing: Crash no longer reproduces
  • Reviewers: TBD

@bnbarham
[Index] Skip mapping locations when there is no buffer ID
4b416b7 
Resolves rdar://143281338.

(cherry picked from commit 59c53ae)
@bnbarham bnbarham requested a review from a team as a code owner January 23, 2025 01:59
@bnbarham
Copy link
Contributor Author

@swift-ci please test

1 similar comment
@bnbarham
Copy link
Contributor Author

@swift-ci please test

@bnbarham bnbarham merged commit f1be5c7 into swiftlang:release/6.1 Jan 23, 2025
5 checks passed
@bnbarham bnbarham deleted the cherry-index-invalid-buffer branch January 23, 2025 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkcsgexi nkcsgexi nkcsgexi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bnbarham @nkcsgexi