[ASTPrinter] Print SPI by default #78838
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`PrintOptions.InterfaceContentKind` was not initialized. Set it to `InteraceMode::Private` by default, so SPI declarations and their `@_spi` attribues are printed. This basically restores the behavior before aba3b6c , and is align with `AccessFilter` being `AccessLevel::Private` by default. rdar://131726756
rintaro
requested review from
ahoppen,
bnbarham,
hamishknight,
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci Please smoke test |
hamishknight
approved these changes
Jan 23, 2025
|
@swift-ci Please smoke test Linux |
|
@swift-ci Please smoke test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PrintOptions.InterfaceContentKindwas not initialized. Set it toInteraceMode::Privateby default, so SPI declarations and their@_spiattribues are printed. This basically restores the behavior beforeaba3b6c , and is align with
AccessFilterbeingAccessLevel::Privateby default.rdar://131726756