[Observation] Add type annotation on cached keypaths #78842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having a KeyPath with an inferred type that contains a "some" type gives an error, like: error: property definition has inferred type '...', involving the 'some' return type of another declaration This is not diagnosed if there is an explicit type, so add an explicit type for the cached keypath when the property has an annotated type. This doesn't resolve cases where there is no type annotation on a property and the inferred type contains a `some` type, but this can always be resolved by adding an explicit type. rdar://143466616
porglezomp
commented
Jan 23, 2025
| } | ||
|
|
||
| /* | ||
| // FIXME: This case is not handled yet. Properties that have no type annotation |
There was a problem hiding this comment.
Question for reviewers: I don't know how best to handle this case.
The simplest thing to do is just disable the optimization when there's no explicit type, but that's an annoying performance hazard when it's idiomatic to use an inferred type for most default-initialized properties.
It's very simple to fix the rare case where this fails (just add a type annotation) but that's still leaving in a source break.
|
@swift-ci please smoke test |
1 similar comment
|
@swift-ci please smoke test |
|
I guess this will be superseded by #78853 disabling the optimization entirely |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having a KeyPath with an inferred type that contains a "some" type gives an error, like:
This is not diagnosed if there is an explicit type, so add an explicit type for the cached keypath when the property has an annotated type. This doesn't resolve cases where there is no type annotation on a property and the inferred type contains a
sometype, but this can always be resolved by adding an explicit type.rdar://143466616