[6.1 🍒][Dependency Scanning] Synchronize on updating Swift dependency lookup results in-parallel #78868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… results in-parallel Resolves rdar://142978967
|
@swift-ci test |
nkcsgexi
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #78856
• Description: When querying multiple Swift module dependencies in-parallel, multiple queries may be updating the hash map data structure where query results are recorded. This is not thread-safe and may cause a re-hashing of the hash map while other threads are accessing it. This change establishes the update of this hash map to be done in a critical section guarded by a lock.
• Risk: Low, this change adds a synchronization mechanism to establish a critical section in the parallel section of the scan, without otherwise changing functionality.
• Reviewed by: @cachemeifyoucan
• Original PR: #78856
• Radar: rdar://142978967