[Serialization] Ensure we run InheritedTypeRequest before serializing inherited type
#78899
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
requested review from
bnbarham,
hamishknight,
rintaro and
xymus
as code owners
|
@swift-ci Please smoke test |
ahoppen
force-pushed
the
rdar141440011
branch
from
0526111 to
c60b8fa
Compare
ahoppen
changed the title
InheritedEntries.getResolvedType to determine type to serialize into interfaceInheritedTypeRequest before serializing inherited type
|
@swift-ci Please smoke test |
ahoppen
force-pushed
the
rdar141440011
branch
from
c60b8fa to
d625e2f
Compare
|
@swift-ci Please smoke test |
ahoppen
force-pushed
the
rdar141440011
branch
from
d625e2f to
355dfcb
Compare
|
@swift-ci Please smoke test |
hamishknight
approved these changes
Jan 27, 2025
…ng inherited type When using `-experimental-skip-all-function-bodies` we don’t run the `TypeCheckSourceFileRequest` and thus don’t go through the decl checker, which calls `InheritedTypeRequest` on all inheritance clauses. This means that the inherited entries are not populated by the time we serialize the module. Trigger the computation of inherited entries by calling `InheritedTypeRequest` during serialization. Unfortunately, we can’t use the type returned by `getResolvedType` for the serialization because `getResolvedType` returns an inverted protocol type for suppressed conformances but during serialization, we want to serialize the suppressed type with a `isSuppressedBit`. We thus need to call `getEntry(i).getType()` again to get the type to serialize. rdar://141440011
ahoppen
force-pushed
the
rdar141440011
branch
from
355dfcb to
2cfcccc
Compare
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
-experimental-skip-all-function-bodieswe don’t run theTypeCheckSourceFileRequestand thus don’t go through the decl checker, which callsInheritedTypeRequeston all inheritance clauses. This means that the inherited entries are not populated by the time we serialize the module. Trigger the computation of inherited entries by callingInheritedTypeRequestduring serialization.Unfortunately, we can’t use the type returned by
getResolvedTypefor the serialization becausegetResolvedTypereturns an inverted protocol type for suppressed conformances but during serialization, we want to serialize the suppressed type with aisSuppressedBit. We thus need to callgetEntry(i).getType()again to get the type to serialize.rdar://141440011
Thanks @hamishknight for the pointer what might be causing this issue.