[Debug info] Retain all type aliases in asttypes mode #78901
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
adrian-prantl
force-pushed
the
143595521
branch
from
7a69490 to
fab120c
Compare
|
@swift-ci test |
augusto2112
reviewed
Jan 27, 2025
| // mode, so we need to artificially keep typealiases alive, since they can | ||
| // appear in reflection metadata. | ||
| if (Opts.DebugInfoLevel < IRGenDebugInfoLevel::DwarfTypes) | ||
| DBuilder.retainType(TypeDef); |
There was a problem hiding this comment.
I thought retainType would retain the type in the IR but not in DWARF, am I wrong?
There was a problem hiding this comment.
There was a problem hiding this comment.
Hmm, does dsymutil keep them too? I think maybe that's what I was remembering. LGTM if yes
There was a problem hiding this comment.
It should not, that's a great point.
There was a problem hiding this comment.
Here is a better solution that builds on top of #78965.
augusto2112
approved these changes
Jan 27, 2025
This cleanup allows for more consistent debug info emission since we depend less on IRGen magic to emit debug info for types.
adrian-prantl
force-pushed
the
143595521
branch
from
fab120c to
057ccfe
Compare
|
@swift-ci test |
…ST types This ensures that debug info for these types is emitted even if this is the only way they are references in the input program. rdar://143595521
adrian-prantl
force-pushed
the
143595521
branch
from
057ccfe to
f213289
Compare
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bound generic types don't reference their type parameters in ASTTypes mode, so we need to artificially keep typealiases alive, since they can appear in reflection metadata.
rdar://143595521