[AutoDiff] Support custom derivatives for @_alwaysEmitIntoClient functions #78908
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging @asl |
kovdan01
force-pushed
the
autodiff-alwaysEmitIntoClient
branch
from
196d2d4 to
c75bc66
Compare
kovdan01
force-pushed
the
autodiff-alwaysEmitIntoClient
branch
from
c75bc66 to
bb90693
Compare
kovdan01
requested review from
a team,
hborla,
slavapestov,
xedin,
eeckstein and
jckarter
as code owners
|
Tagging @JaapWijnen @rxwei |
|
@swift-ci please test |
kovdan01
force-pushed
the
autodiff-alwaysEmitIntoClient
branch
from
bb90693 to
ffa5f81
Compare
|
@swift-ci please test |
kovdan01
force-pushed
the
autodiff-alwaysEmitIntoClient
branch
from
ffa5f81 to
6bb9def
Compare
|
@swift-ci please test |
kovdan01
force-pushed
the
autodiff-alwaysEmitIntoClient
branch
from
6bb9def to
0b9bf45
Compare
|
@swift-ci please test |
|
Would be glad to see feedback from everyone interested |
|
Would be glad to see feedback from everyone interested |
4 similar comments
|
Would be glad to see feedback from everyone interested |
|
Would be glad to see feedback from everyone interested |
|
Would be glad to see feedback from everyone interested |
|
Would be glad to see feedback from everyone interested |
|
@lorentey will you please take a look on stdlib changes? |
|
@jckarter Can you take a look into sil linker part? Thanks! |
|
@kovdan01 Will you please update the description? To summarize what is done, what is the issue, etc. |
Sure, I've updated the PR description. |
3 similar comments
stephentyrone
approved these changes
May 25, 2025
kovdan01
added a commit
to kovdan01/swift
that referenced
this pull request
May 30, 2025
The PR swiftlang#81766 introduced some concrete SIMD operations, but `init(repeating:)` was temporarily disabled due to differentiation testing break. See: stephentyrone@7a00619 This PR contains two changes: 1. Define custom derivatives for concrete `init(repeating:)` so we do not fall into non-differentiability error diagnostic. 2. Add a fix to SIL linker so differentiability witness lookup is done when the original function has both `@_alwaysEmitIntoClient` and `@_transparent`. Similar changes were introduced previously in swiftlang#78908, but they only handled `@_alwaysEmitIntoClient` without `@_transparent`.
kovdan01
added a commit
to kovdan01/swift
that referenced
this pull request
May 30, 2025
The PR swiftlang#81766 introduced some concrete SIMD operations, but `init(repeating:)` was temporarily disabled due to differentiation testing break. See: stephentyrone@7a00619 This PR contains two changes: 1. Define custom derivatives for concrete `init(repeating:)` so we do not fall into non-differentiability error diagnostic. 2. Add a fix to SIL linker so differentiability witness lookup is done when the original function has both `@_alwaysEmitIntoClient` and `@_transparent`. Similar changes were introduced previously in swiftlang#78908, but they only handled `@_alwaysEmitIntoClient` without `@_transparent`.
stephentyrone
pushed a commit
that referenced
this pull request
May 31, 2025
The PR #81766 introduced some concrete SIMD operations, but `init(repeating:)` was temporarily disabled due to differentiation testing break. See: stephentyrone@7a00619 This PR contains two changes: 1. Define custom derivatives for concrete `init(repeating:)` so we do not fall into non-differentiability error diagnostic. 2. Add a fix to SIL linker so differentiability witness lookup is done when the original function has both `@_alwaysEmitIntoClient` and `@_transparent`. Similar changes were introduced previously in #78908, but they only handled `@_alwaysEmitIntoClient` without `@_transparent`. <!-- If this pull request is targeting a release branch, please fill out the following form: https://github.com/swiftlang/.github/blob/main/PULL_REQUEST_TEMPLATE/release.md?plain=1 Otherwise, replace this comment with a description of your changes and rationale. Provide links to external references/discussions if appropriate. If this pull request resolves any GitHub issues, link them like so: Resolves <link to issue>, resolves <link to another issue>. For more information about linking a pull request to an issue, see: https://docs.github.com/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue --> <!-- Before merging this pull request, you must run the Swift continuous integration tests. For information about triggering CI builds via @swift-ci, see: https://github.com/apple/swift/blob/main/docs/ContinuousIntegration.md#swift-ci Thank you for your contribution to Swift! -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider an
@_alwaysEmitIntoClientfunction and a custom derivative definedfor it. Previously, such a combination resulted different errors under different
circumstances.
Sometimes, there were linker errors due to missing derivative function symbol -
these occurred when we tried to find the derivative in a module, while it
should have been emitted into client's code (and it did not happen).
Sometimes, there were SIL verification failures like this:
Linkage and serialization options for the derivative were not handled properly,
and, instead of PublicNonABI linkage, we had Private one which is unsupported
for serialization - but we need to serialize
@_alwaysEmitIntoClientfunctionsso the client's code is able to see them.
This patch resolves the issue and adds proper handling of custom derivatives
of
@_alwaysEmitIntoClientfunctions. Note that either both the function andits custom derivative or none of them should have
@_alwaysEmitIntoClientattribute, mismatch in this attribute is not supported.
The following cases are handled (assume that in each case client's code uses
the derivative).
Both the function and its derivative are defined in a single file in
one module.
Both the function and its derivative are defined in different files which
are compiled to a single module.
The function is defined in one module, its derivative is defined in another
module.
The function and the derivative are defined as members of a protocol
extension in two separate modules - one for the function and one for the
derivative. A struct conforming the protocol is defined in the third
module.
The function and the derivative are defined as members of a struct
extension in two separate modules - one for the function and one for the
derivative.
The changes allow to define derivatives for methods of
SIMD.Fixes #54445