[embedded] Support withoutActuallyEscaping in Embedded Swift #78920
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubamracek
requested review from
MaxDesiatov,
phausler,
mikeash,
al45tair,
rauhul,
zoecarver and
eeckstein
|
@swift-ci please test |
mikeash
approved these changes
Jan 27, 2025
| } | ||
| return result | ||
| } | ||
|
|
||
| @_cdecl("swift_isEscapingClosureAtFileLocation") | ||
| public func swift_isEscapingClosureAtFileLocation(object: Builtin.RawPointer, filename: UnsafePointer<CChar>, filenameLength: Int32, line: Int32, column: Int32, verificationType: CUnsignedInt) -> Bool { | ||
| guard swift_isUniquelyReferenced_native(object: object) else { |
There was a problem hiding this comment.
This will raise a fatal error when object is NULL, whereas the C++ implementation returns false in that case. I'm not sure if it actually matters in practice (is this ever called with NULL legitimately?) but it would probably be good to match them.
There was a problem hiding this comment.
Good point, fixed!
…IRES: swift_test_mode_optimize_none
… match the C++ runtime
|
@swift-ci please test |
al45tair
approved these changes
Jan 28, 2025
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were missing
swift_isEscapingClosureAtFileLocationin the Embedded Swift runtime.rdar://143070738