Runtimes: treat linker warnings as errors #78930
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were previously silently emitting incorrect code for the standard libraries and the warnings were being swallowed by the build system. This was brought to light by the new build system. The code generation issues have been addressed. In order to prevent a backslide, we would ideally use `/WX:4217 /WX:4286`. Unfortunately, `clang-cl` does not support this, so compromise and use `/WX` which treats all linker warnings as errors.
compnerd
requested review from
etcwilde,
edymtt and
justice-adams-apple
as code owners
|
@swift-ci please smoke test |
|
|
Nevermind... that's the future. Misread that as 3.4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were previously silently emitting incorrect code for the standard libraries and the warnings were being swallowed by the build system. This was brought to light by the new build system. The code generation issues have been addressed. In order to prevent a backslide, we would ideally use
/WX:4217 /WX:4286. Unfortunately,clang-cldoes not support this, so compromise and use/WXwhich treats all linker warnings as errors.