[6.1] Sema: Always allow method overrides to be as available as the context #78938
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tshortli
commented
Jan 27, 2025
tshortli
commented
- Explanation: When a method override is as available as the class it's a member of, then it can't be any more available. It doesn't make sense to diagnose such a method as less available than the method it overrides. This regressed recently for methods belonging to classes that are nested inside extensions. The availability of the derived class may be defined by its context, but the compiler was only checking the availability attributes directly on the class.
- Scope: Affects type checking for method overrides.
- Issue/Radar: rdar://143600638
- Original PR: Sema: Always allow method overrides to be as available as the context #78937
- Risk: Low. There should be no source compatibility concerns since this change can only result in more overrides being accepted.
- Testing: New compiler tests.
- Reviewer: TBD
When a method override is as available as the class it's a member of, then it can't be any more available. It doesn't make sense to diagnose such a method as less available than the method it overrides. This regressed recently for methods belonging to classes that are nested inside extensions. The availability of the derived class may be defined by its context, but the compiler was only checking the availability attributes directly on the class. Resolves rdar://143600638.
tshortli
changed the title
tshortli
added
🍒 release cherry pick
|
@swift-ci please test |
nkcsgexi
approved these changes
Jan 27, 2025
tshortli
deleted the
allow-overrides-as-available-as-their-context-6.1
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.