tests: fix some tests for enabling OSSA modules #78943
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It fails with enabled OSSA modules and when run in optimize mode. The problem is that TestErrorDomain (a NSString pointer) is null, but it's not imported as Optional<NSString>. rdar://143681997
Those tests rely on lexical object lifetimes. But lifetimes are only guaranteed for "variables" but not for temporary objects. Storing those objects in variables fixes the issue. This fixes the tests when running them in optimize mode and when OSSA modules are enabled. This is part of rdar://140229560.
…o `_blackHole` Without `_blackHole`, the optimizer may remove or make assumptions about values, which are not intended by the test. This fixes the tests when running them in optimize mode and when OSSA modules are enabled. This is part of rdar://140229560.
eeckstein
requested review from
beccadax,
atrick,
meg-gupta and
nate-chandler
|
@swift-ci smoke test |
|
@swift-ci smoke test windows |
meg-gupta
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporarily disable
ClangImporter/enum-error-execute.swift. It fails with enabled OSSA modules and when run in optimize mode: rdar://143681997Fix lifetimes of objects in two tests. Those tests rely on lexical object lifetimes. But lifetimes are only guaranteed for "variables" but not for temporary objects. Storing those objects in variables fixes the issue.
Make tests more resilient to optimizations by passing values to
_blackHole. Without_blackHole, the optimizer may remove or make assumptions about values, which are not intended by the test.This is part of rdar://140229560.