[cxx-interop] Make borrowing specifiers more precise #78946
Merged
+19
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xazax-hun
requested review from
zoecarver,
hyp,
egorzhdan,
beccadax and
ian-twilightcoder
as code owners
Xazax-hun
force-pushed
the
gaborh/fix-calling-convention
branch
from
d3ee691 to
ad6d8a6
Compare
|
@swift-ci please smoke test |
|
@swift-ci please smoke test macOS |
We do not need to borrow from view objects passed by value but we need to borrow from owners taken by const reference regardless of whether it was annotated using lifetimebound or lifetime_capture_by.
Xazax-hun
force-pushed
the
gaborh/fix-calling-convention
branch
from
ad6d8a6 to
dd3db51
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do not need to borrow from view objects passed by value but we need to borrow from owners taken by const reference regardless of whether it was annotated using lifetimebound or lifetime_capture_by.