[cxx-interop] Support borrowing from self in SwiftifyImport #78947
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xazax-hun
requested review from
a team,
zoecarver,
hyp,
egorzhdan,
beccadax and
ian-twilightcoder
as code owners
hnrklssn
reviewed
Jan 27, 2025
hnrklssn
reviewed
Jan 27, 2025
hnrklssn
reviewed
Jan 27, 2025
Xazax-hun
force-pushed
the
gaborh/lifetimebound-this
branch
from
ed51281 to
2678ff5
Compare
Support adding safe wrappers for APIs returning std::span depending on the this object. This also fixes an issue for APIs with 0 parameters. rdar://139074571
Xazax-hun
force-pushed
the
gaborh/lifetimebound-this
branch
from
2678ff5 to
06e5ead
Compare
|
@swift-ci please smoke test |
|
@swift-ci please smoke test macOS |
hnrklssn
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support adding safe wrappers for APIs returning std::span depending on the this object. This also fixes an issue for APIs with 0 parameters.
rdar://139074571