Skip to content

Sema: Do not diagnose preconcurrency redundancy in implied conformances #78971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 31, 2025
Merged

Sema: Do not diagnose preconcurrency redundancy in implied conformances #78971

merged 2 commits into from
Jan 31, 2025

Conversation

AnthonyLatsis
Copy link
Collaborator

@AnthonyLatsis AnthonyLatsis commented Jan 28, 2025 •
edited
Loading 

@MainActor protocol P1 {}
protocol P2 {
  func foo()
}

protocol P3: P1, P2 {}

struct S: @preconcurrency P3 { // OK, '@preconcurrency' effectful through 'P2'
  func foo() {}
}

Resolves rdar://137794903

@AnthonyLatsis
Copy link
Collaborator Author

@swift-ci please smoke test macOS

@AnthonyLatsis
Copy link
Collaborator Author

@swift-ci please smoke test Linux

@AnthonyLatsis AnthonyLatsis force-pushed the amorphophallus-titanum branch from bd8430c to 9fb198f Compare January 30, 2025 06:36
@AnthonyLatsis
Copy link
Collaborator Author

@swift-ci please smoke test

xedin
xedin approved these changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@xedin xedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable, thank you for fixing this!

@AnthonyLatsis AnthonyLatsis merged commit d585d16 into swiftlang:main Jan 31, 2025
3 checks passed
@AnthonyLatsis AnthonyLatsis deleted the amorphophallus-titanum branch January 31, 2025 08:37
@hborla hborla mentioned this pull request Jun 20, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xedin xedin xedin approved these changes

@ktoso ktoso Awaiting requested review from ktoso ktoso is a code owner

@hborla hborla Awaiting requested review from hborla hborla is a code owner

@slavapestov slavapestov Awaiting requested review from slavapestov slavapestov is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AnthonyLatsis @xedin