[cxx-interop] Fix crash when operator doesn't name parameter in header #78974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susmonteiro
requested review from
zoecarver,
hyp,
egorzhdan,
Xazax-hun,
beccadax and
ian-twilightcoder
as code owners
|
@swift-ci please smoke test |
Xazax-hun
approved these changes
Jan 28, 2025
susmonteiro
force-pushed
the
susmonteiro/operators-unnamed-param
branch
from
9a62fdb to
a4c512a
Compare
|
@swift-ci please smoke test |
egorzhdan
reviewed
Jan 28, 2025
Comment on lines
2217
to
2221
| if (param->getParameterName().empty()) { | ||
| param->setName(ctx.getIdentifier("other")); | ||
| } |
There was a problem hiding this comment.
Since this is changing the name of the parameter of the backing C++ function, can we clone the parameter using ParamDecl::clone, and then change the name of the cloned parameter? I think this would be a good thing to do even if the name doesn't need to be changed, i.e. when if (param->getParameterName().empty()) doesn't trigger.
susmonteiro
force-pushed
the
susmonteiro/operators-unnamed-param
branch
from
a4c512a to
b7c5a47
Compare
|
@swift-ci please smoke test |
1 similar comment
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rdar://140994231