[NFC]: add a FrontendStatsTracer for definite init #78995
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slavapestov
approved these changes
Jan 29, 2025
|
@swift-ci Please smoke test |
|
thanks for kicking off a build @slavapestov. seems the windows job failed, but i'm struggling to determine why (or if it is related to this change)... do the failure logs make sense to you? |
|
@slavapestov @eeckstein – would one of you mind re-trying the windows tests if you get a moment please? or if you can tell if that was an expected failure or flake, can this be merged via some other means? |
auto-merge was automatically disabled
February 15, 2025 16:41
Head branch was pushed to by a user without write access
|
@slavapestov @eeckstein could one of you kick off CI again for this when you have a chance please? |
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds a FrontendStatsTracer to collect performance metrics for definite initialization passes. i'm hoping to use the stats data to inform some potential DI-related performance changes.