[concurrency] Wire up execution(concurrent)/execution(caller) #78997
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to a more logical place. Specifically, rather than performing the interception in ActorIsolationRequest itself after we have returned an actor isolation from getIsolationFromAttributes, just do it in getIsolationFromAttributes. The reason I am doing this is then the code around how we infer isolation in such a case is centralized in getIsolationFromAttributes instead of being in both places. This is a NFC change.
…o the attribute checker. This never belonged in ActorIsolationRequest since it fits perfectly in the attribute checker. This also simplifies the logic before I add code to getIsolationFromAttribute to handle ExecutionAttribute.
…ation to match nonisolated. Specifically, we were attempting to diagnose cases like the following: ```swift @mainactor protocol P { func foo() async } struct S : P { @execution(concurrent) func foo() async {} } ``` This was just an attempt to be more conservative. After some conversations, it came up that nonisolated does not work that way... that is the compiler will accept the following and just hop in the protocol witness thunk: ```swift @mainactor protocol P { func foo() async } struct S : P { nonisolated func foo() async {} } ```
…/execution together.
…ecution({concurrent,caller}).
gottesmm
requested review from
ktoso,
hborla,
slavapestov,
xedin and
jckarter
as code owners
|
@swift-ci smoke test |
xedin
approved these changes
Jan 29, 2025
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just landing this before I do some larger refactoring around flipping the meaning of ActorIsolation::Nonisolated/CallerIsolatedInheritance.