[Backtracing] Declare a CMake dependency on CxxStdlib overlay #79017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Swift code in the Backtracing library enables C++ interop and uses C++ libraries that `#include` C++ stdlib headers. This means that Swift will pull in the C++ stdlib module, along with its overlay. The overlay module needs to be already built at that point. This should fix an occasional compiler error: ``` error: could not find module 'CxxStdlib' for target ```
egorzhdan
force-pushed
the
egorzhdan/backtracing-cxxstdlib
branch
from
eec9cde to
0d52e3f
Compare
|
@swift-ci please test |
|
This is the problem; on Linux it's trying to link against
|
|
I think I understand what's going wrong. Just trying a build locally to verify my fix, then I'll either update this PR or raise one of my own. |
|
This issue was fixed in #79057 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Swift code in the Backtracing library enables C++ interop and uses C++ libraries that
#includeC++ stdlib headers. This means that Swift will pull in the C++ stdlib module, along with its overlay. The overlay module needs to be already built at that point.This should fix an occasional compiler error: