Mo tuples mo problems #7902
Merged
Mo tuples mo problems #7902
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test and merge |
…cts with trivial ownership should never have a cleanup. rdar://29791263
… have the destructure operation yet. rdar://29791263
…ng inst has conflicting ownership. If SIL Ownership is enabled, we still trigger an unreachable. rdar://29791263
gottesmm
force-pushed
the
mo_tuples_mo_problems
branch
from
1354fe0 to
07bcac3
Compare
|
@swift-ci Please smoke test and merge |
1 similar comment
|
@swift-ci Please smoke test and merge |
|
The assertion failure that I hit in XCTest was correct! We had a tuple that was forwarding two types with conflicting ownership! I loosened the assert when SILOwnership is disabled to return a conservative Any result. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[silgen] Fix another tuple explosion -> borrow + copy since we do not have the destructure operation yet.
rdar://29791263