Package CMO: Enable serializing decls imported with @_spiOnly or package import.
#79035
+119
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elsh
requested review from
eeckstein,
hborla,
slavapestov and
xedin
as code owners
elsh
requested review from
nkcsgexi,
xymus,
beccadax,
artemcm,
aschwaighofer and
tshortli
|
@swift-ci test |
…ackage import`. Starting in Swift 6.0, `package` access level and `@_spiOnly` attribute have been increasingly used in import statements. However, existing import filtering prevented serialization of package APIs that included such decls, leading to a significant drop in overall serialization. This PR removes these restrictive filters, and allows decls from SDK or system modules to be included in serialization. rdar://130788606
elsh
force-pushed
the
elsh/pcmo-imports
branch
from
944946c to
67594f1
Compare
elsh
changed the title
@_spiOnly or package import.@_spiOnly or package import.
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting in Swift 6.0,
packageaccess level and@_spiOnlyattribute have been increasingly used in import statements. However, existing import filtering prevented serialization of package APIs that included such decls, leading to a significant drop in overall serialization. This PR removes these restrictive filters, and also allows decls from SDK or system modules to be included in serialization.Resolves rdar://130788606