[build-script] Disable building and installing the Foundation macros for standalone SDKs (#78782) #79040
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for standalone SDKs (swiftlang#78782) Also, remove CMake flag for Android that is now directly set in that repo.
finagolfin
added
🍒 release cherry pick
|
@swift-ci please test |
|
Ping @bnbarham, would you review? |
etcwilde
approved these changes
Feb 5, 2025
|
@finagolfin is the pthreads change supposed to be here? |
|
Yes, the pthreads change is completely unrelated, just happens to be in the same file. That's why I specifically called it out in the commit and the 6.1 backport template above, plus linked to the 6.1 pull that made it redundant. Any problem with including that cleanup too? It already works fine in trunk with this cherry-picked commit. |
DougGregor
approved these changes
Feb 6, 2025
|
No, not a problem. Let's merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: The
--build-swift-tools=0flag is currently used by a few build presets to disable building and installing the compiler and other host tools, like the Observation macros in this repo. Extend it to also disable building and installing the new Foundation macros, plus remove a CMake flag for Android that is now directly set in that repo.Scope: Only used to build standalone SDKs
Issue: None
Original PR: #78782
Risk: None
Testing: Passed all CI on trunk, plus on my Android CI for several months now
Reviewer: @jmschonfeld