[GSB] Start tracking source locations for requirements within protocols. #7906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
|
Note: not ready to merge this until I find a way to avoid the awful QoI regression. |
…urce. NFC cleanup for now, which is staging for a change to provide more information for "abstract protocol requirement" path elements.
…ng sources. The use of floating sources allows us to carry through the protocol information (i.e., "in which protocol do we look for this information?") without immediately forming a new RequirementSource. Yet more NFC refactoring for protocol-requirement sources to carry more pertinent information.
Start reshuffling RequirementSource to store more information about requirements in protocols. As a small step, track the source locations for requirements written within the protocols themselves. Note: there's a QoI regression here where we get duplicated diagnostics (due to multiple generic signature builders being built from a bad signature).
DougGregor
force-pushed
the
requirement-source-sourcelocs
branch
from
0134f1d to
84c5d3e
Compare
|
@swift-ci please smoke test and merge |
1 similar comment
|
@swift-ci please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start reshuffling
RequirementSourceto store more information aboutrequirements in protocols. As a small step, track the source locations
for requirements written within the protocols themselves.
Note: there's a QoI regression here where we get duplicated
diagnostics (due to multiple generic signature builders being built
from a bad signature).