[6.1][Package CMO] downgrade error to warning when checking for deserialization failure #79066
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
elsh
commented
Jan 30, 2025
elsh
commented
- Explanation: Downgrade error to warning when deserialization failure is detected while trying to bypass resilience in the context of Package CMO.
- Scope: Modules built with Package CMO.
- Issues: rdar://143800032
- Original PRs: Package CMO: downgrade error to warning when checking for deserialization errors. #79019
- Risk: Low; emits a warning instead of error
- Testing: unit tests added.
- Reviewers: @nkcsgexi
…ialization errors. Binary module built with Package CMO can be loaded for package-external client modules which do not have direct access to decls that are serialized_for_package. Downgrade build-time error to warning when a deserialization error is found for a decl that should be allowed to access by package-external clients resiliently. rdar://143800032
|
@swift-ci smoke test |
|
@swift-ci test |
nkcsgexi
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.