Add libclang to install_components_with_clang presets #79108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please build toolchain |
|
@swift-ci please smoke test |
|
Verified macOS and Linux toolchains have the new content in the right place. Windows had one lldb test timeout, but should not be impacted by this change. |
owenv
changed the title
|
@swift-ci please build toolchain Windows |
|
It turns out the Windows toolchains already ship libclang.dll, so I think this change is sufficient to ensure it's included in swift.org toolchains for all the supported platforms |
|
@edymtt @shahmishal feel free to suggest any additional testing/investigation that should be done or reviewers who should be added before this lands - it's been a while since I took a close look at the presets |
akyrtzi
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swift Build uses libclang to read serialized diagnostic files, and invoke the module dependency scanner. Add it to the toolchain build.